Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reporting extra examples contributing #2104

Merged
merged 3 commits into from
Jan 29, 2022

Conversation

tkoyama010
Copy link
Member

Overview

We also want to know how our library is used. So I added the reporting example to contributing document.

Details

  • None

@tkoyama010 tkoyama010 marked this pull request as ready for review January 29, 2022 07:09
@github-actions github-actions bot added the documentation Anything related to the documentation/website label Jan 29, 2022
CONTRIBUTING.md Outdated Show resolved Hide resolved
doc/extras/developer_notes.rst Outdated Show resolved Hide resolved
@banesullivan
Copy link
Member

banesullivan commented Jan 29, 2022

Please rebase (or merge main) as I reverted the no-ci checks - sorry for the inconvenience! went ahead and merged so I could verify all is well 😄

banesullivan and others added 2 commits January 29, 2022 13:11
Copy link
Member

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding this!

@akaszynski akaszynski enabled auto-merge (squash) January 29, 2022 21:53
@akaszynski akaszynski merged commit 826c789 into main Jan 29, 2022
@akaszynski akaszynski deleted the doc/add_extra_examples_report branch January 29, 2022 22:18
@tkoyama010
Copy link
Member Author

Thanks you for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the documentation/website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants