Improve gif animation examples #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
| @@ -15,7 +15,7 @@ on: | |||
| - '*' | |||
|
|
|||
| env: | |||
| USE_CACHE: ${{ (github.event_name == 'workflow_dispatch' && github.event.inputs.cache == 'true') || (github.event_name == 'pull_request') }} | |||
| USE_CACHE: ${{ (github.event_name == 'workflow_dispatch' && github.event.inputs.cache == 'true') || (github.event_name == 'pull_request') || (github.event_name == 'push') }} | |||
There was a problem hiding this comment.
This would use the cache on releases, not building from scratch. I think we want to build from scratch on releases
There was a problem hiding this comment.
This would use the cache on releases, not building from scratch
We bump the version on release, and that triggers a cache miss forcing a rebuild. We'll do that both when creating the main branch (e.g. MAJOR.MINOR.dev0), and bumping the main branch to MAJOR.MINOR.PATCH):
pyvista/.github/workflows/docs.yml
Line 76 in cc12a74
There was a problem hiding this comment.
Ah, I forgot that we use the version file's hash for the cache key. Then this should be good by me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #2073 by adding a note in our Create a GIF Movie by noting that when you are using a scalar bar, it's best to turn lighting off.
Additional fixes:
orbit()as setting the camera position and orientation triggers a render. This PR also adds a keyword argument withinpyvista.Plotterto allow you to disable that.Create a GIF Movieexample.mainbranch.