Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ipyvtklink docs #2135

Merged
merged 8 commits into from
Feb 6, 2022
Merged

Update ipyvtklink docs #2135

merged 8 commits into from
Feb 6, 2022

Conversation

banesullivan
Copy link
Member

@banesullivan banesullivan commented Feb 3, 2022 •
edited

Resolves #2050 to update the documentation for using ipyvtklink

Changes:

  • Do not pin versions of packages
  • Do not include itkwidgets
  • Update notes about JupyterLab 3 as ipyvtklinks dependencies handle it now
  • Update to use set_jupyter_backend in example
  • Remove labextension commands
  • Explicitly require JupyterLab >=3

@github-actions github-actions bot added the documentation Anything related to the documentation/website label Feb 3, 2022
@banesullivan
Copy link
Member Author

@saswatac, would you be able to review this for us? 😄

saswatac
saswatac reviewed Feb 4, 2022
View reviewed changes
doc/user-guide/jupyter/ipyvtk_plotting.rst Show resolved Hide resolved
doc/user-guide/jupyter/ipyvtk_plotting.rst Outdated Show resolved Hide resolved
doc/user-guide/jupyter/ipyvtk_plotting.rst Outdated Show resolved Hide resolved
akaszynski
akaszynski approved these changes Feb 5, 2022
View reviewed changes
Copy link
Member

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as I see no issue with this PR. @banesullivan, it's up to you if you want to wait for @saswatac's approval.

@banesullivan banesullivan merged commit 079f9d1 into main Feb 6, 2022
@banesullivan banesullivan deleted the doc/ipyvtklink branch February 6, 2022 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saswatac saswatac saswatac left review comments

@akaszynski akaszynski akaszynski approved these changes

Assignees
No one assigned
Labels
documentation Anything related to the documentation/website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update documentation for using ipyvtklink
3 participants
@banesullivan @saswatac @akaszynski