-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hopf torus #2136
Hopf torus #2136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Thanks for opening your first pull request in PyVista! 🚀 Please make sure you read (skim 😉) our Contributing Guide and abide by our Code of Conduct.
A few things to keep in mind:
- Remember to run the tests locally to make debugging issues easier.
- If you need help writing tests, take a look at the existing ones for inspiration. If you do not know where to start, let
@pyvista/developers
know and we will walk you through it. - All new features should be documented. It helps to write the docstrings for your functions/classes before writing the code. This will help you think about your code design and results in better code.
- No matter what, we are really grateful that you put in the effort to open this PR! ⭐
Windows testing is broken currently but is hopefully fixed in #2137. Don't worry about those checks |
Hi @stla, thank you for your contributions!! Please disregard the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Thanks for posting this.
Aside from the below hard suggestions for trivial typo-grade nitpicks I only have a few general remarks, none of which are crucial:
- I'd probably use
np.pi
if we already have NumPy imported. - I think (hope) our examples quite rigorously follow the
snake_case
function naming convention of the library, so perhaps that would make this example fit even more in. - This is 100% subjective, but I loved the "
nipy_spectral
" version from your discussion post a lot. The flag colormap version seems a bit trippy to me, I could maybe imagine people being uncomfortable looking at it. But thenipy_spectral
is very calm and smooth.
Again, none of these are crucial. This is an excellent example as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks again @stla.
An example: a Hopf torus with a dynamic texture (#2078).