Update incorrectly raised errors to VTKVersionError #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🚀 Thanks for opening your first pull request in PyVista! 🚀 Please make sure you read (skim 😉) our Contributing Guide and abide by our Code of Conduct.
A few things to keep in mind:
- Remember to run the tests locally to make debugging issues easier.
- If you need help writing tests, take a look at the existing ones for inspiration. If you do not know where to start, let
@pyvista/developersknow and we will walk you through it. - All new features should be documented. It helps to write the docstrings for your functions/classes before writing the code. This will help you think about your code design and results in better code.
- No matter what, we are really grateful that you put in the effort to open this PR! ⭐
adeak
reviewed
Feb 12, 2022
adeak
changed the title
akaszynski
reviewed
Feb 12, 2022
Codecov Report
@@ Coverage Diff @@
## main #2199 +/- ##
==========================================
+ Coverage 93.31% 93.47% +0.16%
==========================================
Files 75 74 -1
Lines 15616 15717 +101
==========================================
+ Hits 14572 14692 +120
+ Misses 1044 1025 -19 |
adeak
approved these changes
Feb 13, 2022
There was a problem hiding this comment.
One recommended change to make code coverage happy, otherwise this looks good to me. Great work @not-so-rabh :)
…dd_VTKVersionError * upstream/main: Bump typing-extensions from 4.0.1 to 4.1.1 (#2216) Update imageio requirement from <2.16.0 to <2.17.0 (#2215) Add flake8-black to dependencies (#2213) Fix operater space by black version 22.1.0 (#2212) Style/black and resolve many flake8 issues (#2180) Update link to CONTRIBUTING.rst in greetings action (#2200)
adeak
previously requested changes
Feb 14, 2022
Co-authored-by: Andras Deak <adeak@users.noreply.github.com>
akaszynski
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Replaces instances of incorrectly raised errors which could be replaced by VTKVersionError.
Resolves: #2195