Exclude deprecated plotting/theme.py from coverage #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2261 +/- ##
==========================================
+ Coverage 93.43% 93.45% +0.01%
==========================================
Files 75 74 -1
Lines 15654 15652 -2
==========================================
Hits 14627 14627
+ Misses 1027 1025 -2 |
|
This is ready for review. |
akaszynski
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an annoying warning from coverage in PRs, because the following annotation didn't seem to work for coverage:
pyvista/pyvista/plotting/theme.py
Lines 3 to 5 in 8379d4a
It's reasonable to remove this whole module from coverage instead (as per https://coverage.readthedocs.io/en/stable/source.html#source) and only keep the
#noqaannotation.Setting this as draft until #2175 is merged so as not to induce a merge conflict there.