-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crinkle clip #2316
Crinkle clip #2316
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2316 +/- ##
==========================================
+ Coverage 93.52% 93.53% +0.01%
==========================================
Files 74 74
Lines 15766 15789 +23
==========================================
+ Hits 14745 14769 +24
+ Misses 1021 1020 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this feature. I have a few comments.
Co-authored-by: Andras Deak <adeak@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks Bane!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolve #2313 cc @liangwang0734