Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt remove flaky windows test skips #2321

Merged
merged 4 commits into from
Mar 18, 2022
Merged

Attempt remove flaky windows test skips #2321

merged 4 commits into from
Mar 18, 2022

Conversation

banesullivan
Copy link
Member

Reverts #931 and attempts to remove some other places where Windows is skipped

@github-actions github-actions bot added the maintenance Low-impact maintenance activity label Mar 10, 2022
@banesullivan banesullivan changed the title Attempt remove flaky test skips Attempt remove flaky windows test skips Mar 10, 2022
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #2321 (961784e) into main (9621f50) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2321      +/-   ##
==========================================
- Coverage   93.52%   93.45%   -0.07%     
==========================================
  Files          74       74              
  Lines       15667    15667              
==========================================
- Hits        14652    14642      -10     
- Misses       1015     1025      +10     

@banesullivan banesullivan marked this pull request as ready for review March 15, 2022 23:12
@akaszynski akaszynski merged commit 74891e3 into main Mar 18, 2022
@akaszynski akaszynski deleted the maint/flaky-tests branch March 18, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Low-impact maintenance activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants