Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo of threshold docstring #2355

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Fix typo of threshold docstring #2355

merged 2 commits into from
Mar 17, 2022

Conversation

tkoyama010
Copy link
Member

Overview

Fix typo of threshold docstring by #2349. (Sorry I couldn't find it in review.)

Details

  • None

@github-actions github-actions bot added the documentation Anything related to the documentation/website label Mar 17, 2022
@tkoyama010 tkoyama010 marked this pull request as ready for review March 17, 2022 01:03
@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #2355 (2d73777) into main (951bacb) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2355      +/-   ##
==========================================
- Coverage   93.51%   93.45%   -0.07%     
==========================================
  Files          74       74              
  Lines       15722    15722              
==========================================
- Hits        14703    14693      -10     
- Misses       1019     1029      +10     

Copy link
Contributor

@MatthewFlamm MatthewFlamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! An extremely minor suggestion, which I think reads better. I'm happy either way.

pyvista/core/filters/data_set.py Outdated Show resolved Hide resolved
Co-authored-by: MatthewFlamm <39341281+MatthewFlamm@users.noreply.github.com>
@banesullivan banesullivan merged commit 96c058b into main Mar 17, 2022
@banesullivan banesullivan deleted the doc/typo-threshold branch March 17, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the documentation/website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants