Added CGNSReader in Reader Classes #2413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was marked as an issue.
github-actions
bot
added
the
documentation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🚀 Thanks for opening your first pull request in PyVista! 🚀 Please make sure you read (skim 😉) our Contributing Guide and abide by our Code of Conduct.
A few things to keep in mind:
- Remember to run the tests locally to make debugging issues easier.
- If you need help writing tests, take a look at the existing ones for inspiration. If you do not know where to start, let
@pyvista/developersknow and we will walk you through it. - All new features should be documented. It helps to write the docstrings for your functions/classes before writing the code. This will help you think about your code design and results in better code.
- No matter what, we are really grateful that you put in the effort to open this PR! ⭐
Codecov Report
@@ Coverage Diff @@
## main #2413 +/- ##
==========================================
+ Coverage 93.63% 93.69% +0.06%
==========================================
Files 74 74
Lines 15984 15984
==========================================
+ Hits 14967 14977 +10
+ Misses 1017 1007 -10 |
tkoyama010
approved these changes
Apr 1, 2022
MatthewFlamm
reviewed
Apr 2, 2022
MatthewFlamm
reviewed
Apr 2, 2022
Co-authored-by: MatthewFlamm <39341281+MatthewFlamm@users.noreply.github.com>
akaszynski
approved these changes
Apr 2, 2022
akaszynski
added a commit
that referenced
this pull request
Apr 18, 2022
* Added CGNSReader in Reader Classes It was marked as an issue. * Update doc/api/readers/index.rst Co-authored-by: MatthewFlamm <39341281+MatthewFlamm@users.noreply.github.com> Co-authored-by: Alex Kaszynski <akascap@gmail.com> Co-authored-by: MatthewFlamm <39341281+MatthewFlamm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was marked as an issue.
Overview
Added CGNSReader in Reader Classes
resolves #2410