Make colors iterable and indexable #2415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2415 +/- ##
=======================================
Coverage 93.63% 93.64%
=======================================
Files 74 74
Lines 15984 15994 +10
=======================================
+ Hits 14967 14977 +10
Misses 1017 1017 |
adeak
reviewed
Apr 2, 2022
|
Ah, and codecov has a point: we also need tests. |
Amazing when your CI helps you! |
adeak
reviewed
Apr 3, 2022
|
I've pushed some changes (it was easier than adding them as suggestions). Please review and check if you agree. I think coverage should still be OK but I haven't checked, will have to look at CI. |
adeak
reviewed
Apr 3, 2022
adeak
approved these changes
Apr 4, 2022
akaszynski
approved these changes
Apr 5, 2022
akaszynski
pushed a commit
that referenced
this pull request
Apr 18, 2022
* Quick implementation * Apply code review suggestions, support string indexing, add tests * Apply suggestions from code review * Update channel names and __getitem__ * Add tests * Support negative indices and slices Co-authored-by: Andras Deak <deak.andris@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Support for
pyvista.Color()[i]andfor c in pyvista.Color()to make it backwards compatible with the old 'float tuple' representation.Fixes #2409.
Details
The
float_rgbarepresentation is used for indexing and iteration.