Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CGNSreader import #2423

Merged
merged 2 commits into from
Apr 4, 2022
Merged

Fix CGNSreader import #2423

merged 2 commits into from
Apr 4, 2022

Conversation

MatthewFlamm
Copy link
Contributor

Overview

This hopefully will fully fix #2410 . CGNSReader is now imported into the pyvista namespace.

Details

imports were additionally sorted alphabetically.

@github-actions github-actions bot added the bug Uh-oh! Something isn't working as expected. label Apr 3, 2022
@MatthewFlamm MatthewFlamm changed the title Fix cgns reader import Fix CGNSreader import Apr 3, 2022
@codecov
Copy link

codecov bot commented Apr 3, 2022

Codecov Report

Merging #2423 (5c80c7d) into main (706a37c) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2423      +/-   ##
==========================================
- Coverage   93.69%   93.63%   -0.07%     
==========================================
  Files          74       74              
  Lines       15984    15984              
==========================================
- Hits        14977    14967      -10     
- Misses       1007     1017      +10     

Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this.

@akaszynski akaszynski merged commit 59b4dd4 into main Apr 4, 2022
@akaszynski akaszynski deleted the fix-CGNSReader-namespace branch April 4, 2022 06:57
akaszynski pushed a commit that referenced this pull request Apr 18, 2022
* add CGNSReadsr to __init__

* alphabetize imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Uh-oh! Something isn't working as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CGNSReader not showing up in the documentation
3 participants