-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos #2443
Fix typos #2443
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Thanks for opening your first pull request in PyVista! 🚀 Please make sure you read (skim 😉) our Contributing Guide and abide by our Code of Conduct.
A few things to keep in mind:
- Remember to run the tests locally to make debugging issues easier.
- If you need help writing tests, take a look at the existing ones for inspiration. If you do not know where to start, let
@pyvista/developers
know and we will walk you through it. - All new features should be documented. It helps to write the docstrings for your functions/classes before writing the code. This will help you think about your code design and results in better code.
- No matter what, we are really grateful that you put in the effort to open this PR! ⭐
apologies..should of named the branch |
Codecov Report
@@ Coverage Diff @@
## main #2443 +/- ##
==========================================
- Coverage 93.70% 93.64% -0.07%
==========================================
Files 74 74
Lines 15994 15994
==========================================
- Hits 14987 14977 -10
- Misses 1007 1017 +10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
It is curious that the CI codespell check did not pick this up yet you found them using codespell. This is something that could be looked into outside this PR.
I use other non-standard dictionaries with codespell + more targeted search and replace routines (outside of codespell) + I also am using a codepell-git version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too, thanks a lot!
Found via `codespell -q 3`
Found via
codespell -q 3