Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #2443

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Fix typos #2443

merged 1 commit into from
Apr 7, 2022

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Apr 7, 2022

Found via codespell -q 3

Found via `codespell -q 3`
@github-actions github-actions bot added documentation Anything related to the documentation/website bug Uh-oh! Something isn't working as expected. labels Apr 7, 2022
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks for opening your first pull request in PyVista! 🚀 Please make sure you read (skim 😉) our Contributing Guide and abide by our Code of Conduct.
A few things to keep in mind:

  • Remember to run the tests locally to make debugging issues easier.
  • If you need help writing tests, take a look at the existing ones for inspiration. If you do not know where to start, let @pyvista/developers know and we will walk you through it.
  • All new features should be documented. It helps to write the docstrings for your functions/classes before writing the code. This will help you think about your code design and results in better code.
  • No matter what, we are really grateful that you put in the effort to open this PR! ⭐

@luzpaz
Copy link
Contributor Author

luzpaz commented Apr 7, 2022

apologies..should of named the branchdoc/typos

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #2443 (3a95dd3) into main (0856b08) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2443      +/-   ##
==========================================
- Coverage   93.70%   93.64%   -0.07%     
==========================================
  Files          74       74              
  Lines       15994    15994              
==========================================
- Hits        14987    14977      -10     
- Misses       1007     1017      +10     

@MatthewFlamm MatthewFlamm removed the bug Uh-oh! Something isn't working as expected. label Apr 7, 2022
Copy link
Contributor

@MatthewFlamm MatthewFlamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

It is curious that the CI codespell check did not pick this up yet you found them using codespell. This is something that could be looked into outside this PR.

@luzpaz
Copy link
Contributor Author

luzpaz commented Apr 7, 2022

I use other non-standard dictionaries with codespell + more targeted search and replace routines (outside of codespell) + I also am using a codepell-git version.

Copy link
Member

@adeak adeak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, thanks a lot!

@tkoyama010 tkoyama010 merged commit ce1a374 into pyvista:main Apr 7, 2022
@luzpaz luzpaz deleted the fix/typos branch April 8, 2022 01:29
akaszynski pushed a commit that referenced this pull request Apr 18, 2022
Found via `codespell -q 3`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the documentation/website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants