-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add import/export VRML #2451
Merged
Merged
Add import/export VRML #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## main #2451 +/- ##
=======================================
Coverage 93.69% 93.70%
=======================================
Files 75 76 +1
Lines 16161 16181 +20
=======================================
+ Hits 15142 15162 +20
Misses 1019 1019 |
akaszynski
reviewed
Apr 24, 2022
akaszynski
reviewed
Apr 24, 2022
akaszynski
reviewed
Apr 24, 2022
Co-authored-by: Alex Kaszynski <akascap@gmail.com>
tkoyama010
commented
Apr 25, 2022
Co-authored-by: Alex Kaszynski <akascap@gmail.com>
akaszynski
reviewed
Apr 26, 2022
akaszynski
reviewed
Apr 26, 2022
akaszynski
reviewed
Apr 26, 2022
akaszynski
reviewed
Apr 26, 2022
Co-authored-by: Alex Kaszynski <akascap@gmail.com>
akaszynski
approved these changes
May 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Recommending merge on 1 June 2022 unless further comments are given or issues raised.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add import/export VRML method to Plotter class
resolves #2438
Example
pyvista/tests/example_files/Box.wrl
Lines 1 to 9 in 2ee9c05
Details