Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import/export VRML #2451

Merged
merged 39 commits into from
May 31, 2022
Merged

Add import/export VRML #2451

merged 39 commits into from
May 31, 2022

Conversation

tkoyama010
Copy link
Member

@tkoyama010 tkoyama010 commented Apr 11, 2022

Overview

Add import/export VRML method to Plotter class

resolves #2438

Example

#VRML V2.0 utf8
#shape_box.wrl
Shape {
appearance Appearance {
material Material{}
}
geometry Box{ size 1.0 1.0 1.0 }
}

>>> pl = pyvista.Plotter()
>>> pl.import_vrml("Box.wrl")
>>> pl.show()

import_vrml

Details

  • None

@tkoyama010 tkoyama010 linked an issue Apr 11, 2022 that may be closed by this pull request
@tkoyama010 tkoyama010 added the enhancement Changes that enhance the library label Apr 11, 2022
@codecov
Copy link

codecov bot commented Apr 24, 2022

Codecov Report

Merging #2451 (9742490) into main (c813a56) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2451   +/-   ##
=======================================
  Coverage   93.69%   93.70%           
=======================================
  Files          75       76    +1     
  Lines       16161    16181   +20     
=======================================
+ Hits        15142    15162   +20     
  Misses       1019     1019           

@tkoyama010 tkoyama010 marked this pull request as ready for review April 24, 2022 08:16
pyvista/plotting/plotting.py Outdated Show resolved Hide resolved
pyvista/plotting/plotting.py Outdated Show resolved Hide resolved
pyvista/plotting/plotting.py Outdated Show resolved Hide resolved
Co-authored-by: Alex Kaszynski <akascap@gmail.com>
@tkoyama010 tkoyama010 marked this pull request as draft April 27, 2022 22:53
@tkoyama010 tkoyama010 marked this pull request as ready for review April 30, 2022 10:15
Copy link
Member

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Recommending merge on 1 June 2022 unless further comments are given or issues raised.

@tkoyama010 tkoyama010 merged commit db62644 into main May 31, 2022
@tkoyama010 tkoyama010 deleted the feat/2438-vrml-export branch May 31, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Changes that enhance the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VRML export
2 participants