add additional kwargs to open_gif #2484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2484 +/- ##
==========================================
+ Coverage 93.67% 93.70% +0.03%
==========================================
Files 75 75
Lines 16052 16052
==========================================
+ Hits 15036 15041 +5
+ Misses 1016 1011 -5 |
tkoyama010
approved these changes
Apr 19, 2022
adeak
reviewed
Apr 19, 2022
Comment on lines
+3397
to
+3399
| fps : float, optional | ||
| The number of frames per second. If duration is not given, the | ||
| duration for each frame is set to 1/fps. Default 10. |
There was a problem hiding this comment.
There's mention of "if duration is not given", but duration is not an explicit kwarg. Perhaps it should be? Or we should make it explicit that this can be passed on to get_writer? And can we give a better pointer for kwarg documentation than imageio.get_writer()? (See also my comment for #2489)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #2468 by adding additional keyword arguments to open_gif and improving the docstring.
Bonus (there always is)
Added a unit test for
open_gif, because apparently it's part of the 6.33 we're not covering in our tests.