Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not automatically set hidden line removal in document theme #2488

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

hakostra
Copy link
Contributor

This resolves issue #2353 See that issue for a complete description of the problem.

@adeak
Copy link
Member

adeak commented Apr 19, 2022

Thanks for catching and fixing this. I wonder if we need to manually set this again for our doc build (cc @akaszynski). Assuming the line was added on purpose.

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #2488 (063729f) into main (8179107) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2488      +/-   ##
==========================================
- Coverage   93.77%   93.70%   -0.07%     
==========================================
  Files          75       75              
  Lines       16073    16072       -1     
==========================================
- Hits        15072    15061      -11     
- Misses       1001     1011      +10     

@tkoyama010 tkoyama010 added the bug Uh-oh! Something isn't working as expected. label Apr 19, 2022
@akaszynski
Copy link
Member

self.hidden_line_removal = True
There's an issue with a few of our plots like as in https://docs.pyvista.org/api/core/_autosummary/pyvista.PolyDataFilters.boolean_intersection.html#pyvista.PolyDataFilters.boolean_intersection, but I can change this on a plot by plot basis.

I'll rebuild the docs once this is merged and once we're on 0.34.2 (probably next week considering the volume of bugfix PRs).

@akaszynski akaszynski merged commit 6bb517c into pyvista:main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Uh-oh! Something isn't working as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants