Fix download_single_sphere_animation
#2492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2492 +/- ##
=======================================
Coverage 93.70% 93.70%
=======================================
Files 75 75
Lines 16072 16072
=======================================
Hits 15061 15061
Misses 1011 1011 |
|
Do I understand correctly that this also needs a chache purge? |
Correct, it was the exact same problem as the dual sphere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This download function was trying to download a folder. This is corrected to use a zip file.
This requires pyvista/vtk-data#11 to be merged first.
Details
An example was added similar to
download_dual_sphere_animation