Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix example for reading exodus file #2495

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Conversation

j-bowhay
Copy link
Contributor

Overview

Currently the example in the documentation is incorrect. This pr fixes this.

Details

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks for opening your first pull request in PyVista! 🚀 Please make sure you read (skim 😉) our Contributing Guide and abide by our Code of Conduct.
A few things to keep in mind:

  • Remember to run the tests locally to make debugging issues easier.
  • If you need help writing tests, take a look at the existing ones for inspiration. If you do not know where to start, let @pyvista/developers know and we will walk you through it.
  • All new features should be documented. It helps to write the docstrings for your functions/classes before writing the code. This will help you think about your code design and results in better code.
  • No matter what, we are really grateful that you put in the effort to open this PR! ⭐

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #2495 (5c713d5) into main (6bb517c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2495   +/-   ##
=======================================
  Coverage   93.70%   93.70%           
=======================================
  Files          75       75           
  Lines       16072    16072           
=======================================
  Hits        15061    15061           
  Misses       1011     1011           

@tkoyama010 tkoyama010 added the documentation Anything related to the documentation/website label Apr 21, 2022
Copy link
Member

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@akaszynski akaszynski merged commit d355ed7 into pyvista:main Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the documentation/website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants