add linked views for pythreejs #2518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2518 +/- ##
=======================================
Coverage 93.77% 93.77%
=======================================
Files 76 76
Lines 16168 16186 +18
=======================================
+ Hits 15161 15179 +18
Misses 1007 1007 |
|
@pyvista/developers, this is ready for review. |
tkoyama010
reviewed
May 1, 2022
adeak
reviewed
May 6, 2022
Co-authored-by: Andras Deak <adeak@users.noreply.github.com>
adeak
reviewed
May 7, 2022
Co-authored-by: Andras Deak <adeak@users.noreply.github.com>
Co-authored-by: Andras Deak <adeak@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves #2499 by adding linked views for
pythreejs.Bonus (as always)
After some investigation, I've discovered that it's possible to output a scene using the
panelbackend. I've added it here as well since #2499 pointed out thatpanelworks quite well for text and that's unsupported for now forpythreejs.