Make intersphinx update script more robust #2534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adeak
added
documentation
Codecov Report
@@ Coverage Diff @@
## main #2534 +/- ##
==========================================
+ Coverage 93.72% 93.78% +0.06%
==========================================
Files 75 75
Lines 16120 16120
==========================================
+ Hits 15108 15118 +10
+ Misses 1012 1002 -10 |
adeak
changed the title
|
FYI: In case you didn't see it, scipy implemented a full docs layout fix. This includes fixing the aberrant hosting location of the v1.8.0 docs, so if you have anything pointing specifically to 1.8.0, it'll need an update. |
|
Thanks a lot @bskinn. I did see it today on the SciPy mailing list, but haven't had the time yet to look into this regarding PyVista. After a cursory glance earlier today it seemed to me that we don't even use any SciPy intersphinx links (but we could/should in a few places which I intend to look into). |
|
According to scipy/scipy#14267 (comment) we are using the correct final intersphinx URL as of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2285 introduced a broken SciPy intersphinx mapping file, because the URL changed and the older path became a redirect (see also scipy/scipy#14267).
curldoesn't follow redirects automatically so instead of the intersphinx mapping file the redirect's HTML response was saved instead.In hindsight the -88 KB change of the corresponding file at https://github.com/pyvista/pyvista/pull/2285/files is suspicious, but I wouldn't have noticed this either.
I've updated every intersphinx mapping while I'm at it.