Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add example for Plotter.bounds #2546

Merged
merged 5 commits into from
May 4, 2022
Merged

add example for Plotter.bounds #2546

merged 5 commits into from
May 4, 2022

Conversation

akaszynski
Copy link
Member

@akaszynski akaszynski commented May 2, 2022 •
edited

This PR adds a simple example for Plotter.bounds.

See #1629

@github-actions github-actions bot added the documentation Anything related to the documentation/website label May 2, 2022
@akaszynski akaszynski changed the title add bounds example add more plotting examples May 2, 2022
@codecov
Copy link

codecov bot commented May 2, 2022 •
edited

Codecov Report

Merging #2546 (1b0dc24) into main (f1f4df2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2546   +/-   ##
=======================================
  Coverage   93.72%   93.72%           
=======================================
  Files          75       75           
  Lines       16120    16120           
=======================================
  Hits        15108    15108           
  Misses       1012     1012

tkoyama010
tkoyama010 approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akaszynski
Copy link
Member Author

This will have some conflicts with #2551, converting to draft and will merge after #2551.

@akaszynski akaszynski marked this pull request as draft May 3, 2022 16:56
@akaszynski akaszynski changed the title add more plotting examples add example for Plotter.bounds May 4, 2022
@akaszynski akaszynski marked this pull request as ready for review May 4, 2022 20:33
@akaszynski akaszynski enabled auto-merge (squash) May 4, 2022 20:33
@akaszynski akaszynski merged commit 784243d into main May 4, 2022
@akaszynski akaszynski deleted the docs/bounds_example branch May 4, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkoyama010 tkoyama010 tkoyama010 approved these changes

Assignees
No one assigned
Labels
documentation Anything related to the documentation/website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akaszynski @tkoyama010