-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dynamic flask example #2552
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2552 +/- ##
==========================================
- Coverage 93.72% 93.69% -0.03%
==========================================
Files 75 75
Lines 16120 16160 +40
==========================================
+ Hits 15108 15141 +33
- Misses 1012 1019 +7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the addition. I have been waiting for this feature plotting PyVista dynamic in html. I'm not very familiar with flask, but is it necessary not to keep the static example?
I guess I didn't do a good job explaining this in the documentation, but the static example is still there. I'll update the docs and potentially rename the directories. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sorry. It's my fault. In that way LGTM.
This PR adds a dynamic flask example to supplement the existing static example and resolves #2459.
127.0.0.1_5000.mp4