Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dynamic flask example #2552

Merged
merged 6 commits into from
May 10, 2022
Merged

add dynamic flask example #2552

merged 6 commits into from
May 10, 2022

Conversation

akaszynski
Copy link
Member

@akaszynski akaszynski commented May 2, 2022

This PR adds a dynamic flask example to supplement the existing static example and resolves #2459.

127.0.0.1_5000.mp4

@github-actions github-actions bot added documentation Anything related to the documentation/website enhancement Changes that enhance the library labels May 2, 2022
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #2552 (a1592a0) into main (f1f4df2) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2552      +/-   ##
==========================================
- Coverage   93.72%   93.69%   -0.03%     
==========================================
  Files          75       75              
  Lines       16120    16160      +40     
==========================================
+ Hits        15108    15141      +33     
- Misses       1012     1019       +7     

Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition. I have been waiting for this feature plotting PyVista dynamic in html. I'm not very familiar with flask, but is it necessary not to keep the static example?

@akaszynski
Copy link
Member Author

I'm not very familiar with flask, but is it necessary not to keep the static example?

I guess I didn't do a good job explaining this in the documentation, but the static example is still there. I'll update the docs and potentially rename the directories.

Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry. It's my fault. In that way LGTM.

@akaszynski akaszynski merged commit a6d21b0 into main May 10, 2022
@akaszynski akaszynski deleted the feat/dynamic_flask branch May 10, 2022 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the documentation/website enhancement Changes that enhance the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embedding Pyvista into flask with interactive UI.
2 participants