-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added documentation for getting started with wsl2 on windows #2553
added documentation for getting started with wsl2 on windows #2553
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Thanks for opening your first pull request in PyVista! 🚀 Please make sure you read (skim 😉) our Contributing Guide and abide by our Code of Conduct.
A few things to keep in mind:
- Remember to run the tests locally to make debugging issues easier.
- If you need help writing tests, take a look at the existing ones for inspiration. If you do not know where to start, let
@pyvista/developers
know and we will walk you through it. - All new features should be documented. It helps to write the docstrings for your functions/classes before writing the code. This will help you think about your code design and results in better code.
- No matter what, we are really grateful that you put in the effort to open this PR! ⭐
Codecov Report
@@ Coverage Diff @@
## main #2553 +/- ##
=======================================
Coverage 93.72% 93.72%
=======================================
Files 75 75
Lines 16120 16120
=======================================
Hits 15108 15108
Misses 1012 1012 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielgrzenda Thank you for adding this. Document for wsl2 is a very important contribution. I have some fixes. If you approve it please commit suggestion.
Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @danielgrzenda! |
Overview
Added documentation for getting started with wsl2 on windows. Added directions for:
jupyter lab
with VTK and headless Xserverjupyter lab
withpythreejs