-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added decompose_polyhedra property in OpenFOAMReader #2563
Added decompose_polyhedra property in OpenFOAMReader #2563
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Thanks for opening your first pull request in PyVista! 🚀 Please make sure you read (skim 😉) our Contributing Guide and abide by our Code of Conduct.
A few things to keep in mind:
- Remember to run the tests locally to make debugging issues easier.
- If you need help writing tests, take a look at the existing ones for inspiration. If you do not know where to start, let
@pyvista/developers
know and we will walk you through it. - All new features should be documented. It helps to write the docstrings for your functions/classes before writing the code. This will help you think about your code design and results in better code.
- No matter what, we are really grateful that you put in the effort to open this PR! ⭐
Codecov Report
@@ Coverage Diff @@
## main #2563 +/- ##
=======================================
Coverage 93.72% 93.72%
=======================================
Files 75 75
Lines 16120 16128 +8
=======================================
+ Hits 15108 15116 +8
Misses 1012 1012 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test for this behavior? We don't have suitable data, but we can test something like
reader.decompose_polyhedra = False
assert not decompose_polyhedra
reader.decompose_polyhedra = True
assert decompose_polyhedra
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great first PR!
Overview
This new feature exposes the
DecomposePolyhedra
property from vtk to OpenFOAMReader.This resolves #2559.
Details
We would like to expose the
DecomposePolyhedra
property from the vtkOpenFOAMReader (class definition). So we decided to add a property nameddecompose_polyhedra
to OpenFOAMReader.