-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ".xyz" extension to PointSet.save #2571
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2571 +/- ##
=======================================
Coverage 93.69% 93.69%
=======================================
Files 75 75
Lines 16159 16160 +1
=======================================
+ Hits 15140 15141 +1
Misses 1019 1019 |
This is a good idea. It would also be nice to have a reader for xyz files and we could test the roundtrip. vtkSimplePointsReader |
One problem I see with this format is that I don't think that any point_data will get saved. Maybe the best we can do is writing it to vtp or the xml version? |
Thanks for the comment. As you say we can casting PointSet to PolyData. pset.cast_to_polydata().save("pset.vtk") |
Anyway, it would be useful to add xyz file output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to merge as-is. We can add a specialized reader as a next step.
Overview
PointSet.save
cannot be written because_WRITER
does not exist, and an error always occurs. Therefore, in this PR, I have clarified which extension to specify by defining_WRITER
. IMO, the only Writer object that can be used withPointSet
isvtkSimplePointsWriter
, which creates xyz file. (If there are other Writers that can be added, please point them out.)resolves #2556
Details