-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small change to avoid raising exception #2586
Small change to avoid raising exception #2586
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Thanks for opening your first pull request in PyVista! 🚀 Please make sure you read (skim 😉) our Contributing Guide and abide by our Code of Conduct.
A few things to keep in mind:
- Remember to run the tests locally to make debugging issues easier.
- If you need help writing tests, take a look at the existing ones for inspiration. If you do not know where to start, let
@pyvista/developers
know and we will walk you through it. - All new features should be documented. It helps to write the docstrings for your functions/classes before writing the code. This will help you think about your code design and results in better code.
- No matter what, we are really grateful that you put in the effort to open this PR! ⭐
Thanks for the PR! Do you mean that there was a bug that caused an error here in certain situations? |
Codecov Report
@@ Coverage Diff @@
## main #2586 +/- ##
=======================================
Coverage 93.69% 93.69%
=======================================
Files 75 75
Lines 16160 16156 -4
=======================================
- Hits 15141 15138 -3
+ Misses 1019 1018 -1 |
No, but I was debugging another package allowing "caught exceptions" and I saw this one, which was quite easy to fix. |
OK, thank you. I wasn't sure if there was some edge case I was missing :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks again. This is a lot more readable.
Small change to avoid raising an exception.