Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning tests of integer vectors #2664

Merged
merged 10 commits into from
Jun 4, 2022
Merged

Add warning tests of integer vectors #2664

merged 10 commits into from
Jun 4, 2022

Conversation

tkoyama010
Copy link
Member

Overview

resolves #2660

Details

  • None

tkoyama010
tkoyama010 commented May 17, 2022
View reviewed changes
tests/test_filters.py Outdated Show resolved Hide resolved
@tkoyama010 tkoyama010 marked this pull request as ready for review May 17, 2022 04:07
@tkoyama010 tkoyama010 closed this May 17, 2022
@tkoyama010 tkoyama010 deleted the bug/transform branch May 17, 2022 04:08
@tkoyama010 tkoyama010 restored the bug/transform branch May 17, 2022 04:08
@tkoyama010 tkoyama010 reopened this May 17, 2022
@tkoyama010 tkoyama010 added the bug Uh-oh! Something isn't working as expected. label May 17, 2022
@codecov
Copy link

codecov bot commented May 17, 2022 •
edited

Codecov Report

Merging #2664 (6a22388) into main (02fa9c0) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2664      +/-   ##
==========================================
- Coverage   93.84%   93.77%   -0.07%     
==========================================
  Files          76       76              
  Lines       16189    16189              
==========================================
- Hits        15192    15182      -10     
- Misses        997     1007      +10

tkoyama010
tkoyama010 commented May 17, 2022
View reviewed changes
tests/test_filters.py Outdated Show resolved Hide resolved
tests/test_filters.py Outdated Show resolved Hide resolved
tkoyama010
tkoyama010 commented May 17, 2022
View reviewed changes
tests/test_filters.py Outdated Show resolved Hide resolved
tests/test_filters.py Outdated Show resolved Hide resolved
tkoyama010
tkoyama010 commented May 17, 2022
View reviewed changes
tests/test_filters.py Outdated Show resolved Hide resolved
@tkoyama010 tkoyama010 marked this pull request as draft May 17, 2022 06:07
@tkoyama010 tkoyama010 marked this pull request as ready for review May 17, 2022 06:07
@tkoyama010 tkoyama010 marked this pull request as draft May 19, 2022 22:29
@akaszynski akaszynski marked this pull request as ready for review June 2, 2022 19:02
@akaszynski
Copy link
Member

Comment #2664 (comment) should be resolved as of 6a22388.

@akaszynski akaszynski merged commit 413beeb into main Jun 4, 2022
@akaszynski akaszynski deleted the bug/transform branch June 4, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewFlamm MatthewFlamm MatthewFlamm left review comments

@akaszynski akaszynski akaszynski approved these changes

Assignees
No one assigned
Labels
bug Uh-oh! Something isn't working as expected.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

failure transforming 3 size cell vectors
3 participants
@tkoyama010 @akaszynski @MatthewFlamm