Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include MultipleLines in documentation #2683

Merged
merged 1 commit into from
May 23, 2022
Merged

Conversation

StefRe
Copy link
Contributor

@StefRe StefRe commented May 23, 2022

Overview

MultipleLines was introduced in #2304 but not included in the documentation.
Fix numpydoc warning "RT03: Return value has no description" by adding a description.
Resolves #2679.

@github-actions github-actions bot added documentation Anything related to the documentation/website bug Uh-oh! Something isn't working as expected. labels May 23, 2022
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks for opening your first pull request in PyVista! 🚀 Please make sure you read (skim 😉) our Contributing Guide and abide by our Code of Conduct.
A few things to keep in mind:

  • Remember to run the tests locally to make debugging issues easier.
  • If you need help writing tests, take a look at the existing ones for inspiration. If you do not know where to start, let @pyvista/developers know and we will walk you through it.
  • All new features should be documented. It helps to write the docstrings for your functions/classes before writing the code. This will help you think about your code design and results in better code.
  • No matter what, we are really grateful that you put in the effort to open this PR! ⭐

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #2683 (76462b9) into main (0ef3f55) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2683   +/-   ##
=======================================
  Coverage   93.70%   93.70%           
=======================================
  Files          75       75           
  Lines       16178    16178           
=======================================
  Hits        15160    15160           
  Misses       1018     1018           

MultipleLines was introduced in pyvista#2304 but not included in the documentation.
Fix numpydoc warning "RT03: Return value has no description" by adding a description.
@StefRe
Copy link
Contributor Author

StefRe commented May 23, 2022

The error

xvfb-run: error: Xvfb failed to start

seems unrelated to this PR.

Copy link
Contributor

@MatthewFlamm MatthewFlamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm neutral on whether we should add the additional line to the Returns section.

@StefRe
Copy link
Contributor Author

StefRe commented May 23, 2022

@MatthewFlamm I just added it because numpydoc complained about "RT03: Return value has no description". So it has no other benefit than just to silence the warning.

@akaszynski akaszynski merged commit 7c12f0f into pyvista:main May 23, 2022
@StefRe StefRe deleted the patch-1 branch May 23, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Uh-oh! Something isn't working as expected. documentation Anything related to the documentation/website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation of MultipleLines
3 participants