-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include MultipleLines in documentation #2683
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Thanks for opening your first pull request in PyVista! 🚀 Please make sure you read (skim 😉) our Contributing Guide and abide by our Code of Conduct.
A few things to keep in mind:
- Remember to run the tests locally to make debugging issues easier.
- If you need help writing tests, take a look at the existing ones for inspiration. If you do not know where to start, let
@pyvista/developers
know and we will walk you through it. - All new features should be documented. It helps to write the docstrings for your functions/classes before writing the code. This will help you think about your code design and results in better code.
- No matter what, we are really grateful that you put in the effort to open this PR! ⭐
Codecov Report
@@ Coverage Diff @@
## main #2683 +/- ##
=======================================
Coverage 93.70% 93.70%
=======================================
Files 75 75
Lines 16178 16178
=======================================
Hits 15160 15160
Misses 1018 1018 |
MultipleLines was introduced in pyvista#2304 but not included in the documentation. Fix numpydoc warning "RT03: Return value has no description" by adding a description.
The error
seems unrelated to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm neutral on whether we should add the additional line to the Returns
section.
@MatthewFlamm I just added it because numpydoc complained about "RT03: Return value has no description". So it has no other benefit than just to silence the warning. |
Overview
MultipleLines was introduced in #2304 but not included in the documentation.
Fix numpydoc warning "RT03: Return value has no description" by adding a description.
Resolves #2679.