Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note in regards to issues when installing pre-commit #2709

Merged
merged 2 commits into from
May 30, 2022

Conversation

akaszynski
Copy link
Member

Add a note in regards to installing pre-commit this comment.

@github-actions github-actions bot added the documentation Anything related to the documentation/website label May 27, 2022
@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #2709 (14db08f) into main (fb899da) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2709   +/-   ##
=======================================
  Coverage   93.76%   93.76%           
=======================================
  Files          75       75           
  Lines       16148    16148           
=======================================
  Hits        15141    15141           
  Misses       1007     1007           

Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CONTRIBUTING.rst Outdated Show resolved Hide resolved
Copy link
Member

@adeak adeak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formally requesting changes to make sure this isn't merged yet.

CONTRIBUTING.rst Outdated Show resolved Hide resolved
Copy link
Member

@adeak adeak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks.

@akaszynski akaszynski merged commit 975645d into main May 30, 2022
@akaszynski akaszynski deleted the docs/pre-commit-install-note branch May 30, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the documentation/website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants