-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image cache testing for Mac and Windows #2716
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2716 +/- ##
==========================================
- Coverage 93.82% 93.76% -0.07%
==========================================
Files 75 75
Lines 16148 16148
==========================================
- Hits 15151 15141 -10
- Misses 997 1007 +10 |
Just so I understand correctly, this means that we don't need a separate image cache for each OS after all, at the cost of skipping this small handful of flaky tests? |
Exactly. MacOS only needed one change, Windows would have just needed two skips but for OSMesa. 90% testing is better than no testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as-is, thanks. One very small suggestion that's not critical at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Add in image cache testing for MacOS and Windows based on the comment in #2441.
Changes:
test_plot
as we're usingfull_screen=True
here and this does not work with unit testing within MacOS. Thefull_screen
parameter actually changes the window since, while on Linux it does not.