Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up documentation build #2721

Merged
merged 4 commits into from
Jun 2, 2022
Merged

Clean up documentation build #2721

merged 4 commits into from
Jun 2, 2022

Conversation

akaszynski
Copy link
Member

This PR fixes a few annoying warnings that occur during our documentation build.

examples/01-filter/compute-volume.py

2022-05-31 20:51:29.891 (   0.661s) [        A417A000]         vtkDataSet.cxx:632   WARN| vtkUnstructuredGrid (0x3449120): Cell array RegionId with 1 components, has 553 tuples but there are only 518 cells
2022-05-31 20:51:29.929 (   0.699s) [        A417A000]         vtkDataSet.cxx:632   WARN| vtkUnstructuredGrid (0x3449120): Cell array RegionId with 1 components, has 553 tuples but there are only 518 cells

This is caused by a malformed regionID array when largest=True when using the connectivity filter. Since there's no reason to include this array in the first place when only extracting one region, simply remove it.

pyvista.examples.downloads.download_cgns_multi:

2022-05-30T22:45:01.7704924Z 2022-05-30 22:45:01.770 ( 410.807s) [        2EFFE740]      vtkCGNSReader.cxx:2079  WARN| vtkCGNSReader (0x55fe9a6272b0): Skipping BC_t node: BC_t type 'BCSymmetryPlane' not supported yet.
2022-05-30T22:45:01.7706086Z 2022-05-30 22:45:01.770 ( 410.807s) [        2EFFE740]      vtkCGNSReader.cxx:2079  WARN| vtkCGNSReader (0x55fe9a6272b0): Skipping BC_t node: BC_t type 'BCExtrapolate' not supported yet.
2022-05-30T22:45:01.7707238Z 2022-05-30 22:45:01.770 ( 410.807s) [        2EFFE740]      vtkCGNSReader.cxx:2079  WARN| vtkCGNSReader (0x55fe9a6272b0): Skipping BC_t node: BC_t type 'BCFarfield' not supported yet.
2022-05-30T22:45:01.7708011Z 2022-05-30 22:45:01.770 ( 410.807s) [        2EFFE740]      vtkCGNSReader.cxx:2079  WARN| vtkCGNSReader (0x55fe9a6272b0): Skipping BC_t node: BC_t type 'BCFarfield' not supported yet.

This is caused by loading the boundary patch load_boundary_patch. This has been disabled for this dataset.

Unnecessary file

The file my_theme.json is written when running doctests. The fix is to skip this test.

@github-actions github-actions bot added the bug Uh-oh! Something isn't working as expected. label May 31, 2022
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #2721 (50a35ff) into main (975645d) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2721      +/-   ##
==========================================
- Coverage   93.82%   93.77%   -0.06%     
==========================================
  Files          75       76       +1     
  Lines       16148    16171      +23     
==========================================
+ Hits        15151    15164      +13     
- Misses        997     1007      +10     

Copy link
Member

@adeak adeak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks. It's unlikely that anyone would be relying on the broken RegionId to, I don't know, get the label of the largest region anyway, or get the number of regions, right? I guess they could just switch to largest=False and pick out the largest ones themselves.

@akaszynski
Copy link
Member Author

Looks good to me, thanks. It's unlikely that anyone would be relying on the broken RegionId to, I don't know, get the label of the largest region anyway, or get the number of regions, right? I guess they could just switch to largest=False and pick out the largest ones themselves.

I'm reminded of
image


I think we're ok with removing this. regionID is undocumented (in our docs) anyway.

@akaszynski akaszynski merged commit 02fa9c0 into main Jun 2, 2022
@akaszynski akaszynski deleted the fix/ignore_regionid branch June 2, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Uh-oh! Something isn't working as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants