PolyData.*_normals properties use existing Normals if they exist
#2737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2737 +/- ##
==========================================
- Coverage 93.83% 93.82% -0.02%
==========================================
Files 76 76
Lines 16194 16199 +5
==========================================
+ Hits 15195 15198 +3
- Misses 999 1001 +2 |
akaszynski
reviewed
Jun 3, 2022
akaszynski
reviewed
Jun 3, 2022
akaszynski
approved these changes
Jun 3, 2022
Co-authored-by: Alex Kaszynski <akascap@gmail.com>
Co-authored-by: Alex Kaszynski <akascap@gmail.com>
|
Thanks @akaszynski , accepted your changes - this is ready to be merged when the doc build passes. |
Will wait 24 hours given our agreement in #2245 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
PolyData.*_normalsproperties use existingNormalsif they exist. Based on discussion in #2728