Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PyPI link like numpy and pandas #2742

Merged
merged 4 commits into from
Jun 5, 2022
Merged

Conversation

tkoyama010
Copy link
Member

@tkoyama010 tkoyama010 commented Jun 4, 2022

Overview

This Pull Request improves links in PyPI page like numpy and pandas using project_urls.

main This PR
image image

Details

@github-actions github-actions bot added the maintenance Low-impact maintenance activity label Jun 4, 2022
@tkoyama010 tkoyama010 marked this pull request as ready for review June 4, 2022 09:44
@tkoyama010 tkoyama010 marked this pull request as draft June 4, 2022 09:45
setup.py Outdated Show resolved Hide resolved
@tkoyama010 tkoyama010 marked this pull request as ready for review June 4, 2022 09:45
setup.py Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 4, 2022

Codecov Report

Merging #2742 (21ee815) into main (0d30747) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2742   +/-   ##
=======================================
  Coverage   93.82%   93.82%           
=======================================
  Files          76       76           
  Lines       16209    16209           
=======================================
  Hits        15208    15208           
  Misses       1001     1001           

Copy link
Member

@adeak adeak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea, thanks! Just a couple of small remarks.

setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
Co-authored-by: Andras Deak <adeak@users.noreply.github.com>
Copy link
Member

@adeak adeak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, thanks!

@tkoyama010
Copy link
Member Author

tkoyama010 commented Jun 4, 2022

Suggest merging on June 6th.

@tkoyama010 tkoyama010 merged commit 120fb4d into main Jun 5, 2022
@tkoyama010 tkoyama010 deleted the maint/improve-pypi-link branch June 5, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Low-impact maintenance activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants