Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gallery building flag to environment variables #2745

Merged
merged 1 commit into from
Jun 5, 2022

Conversation

adeak
Copy link
Member

@adeak adeak commented Jun 5, 2022

This is an alternative to #2744, cc. @akaszynski

I could reproduce the warnings being emitted during a local doc build with OSMesa-built VTK. The only possible cause is that the pyvista.BUILDING_GALLERY flag was sometimes unset during doc building, for which the only reasonable explanation is that sphinx spawns subprocesses that don't themselves execute doc/conf.py. So setting the PYVISTA_BUILDING_GALLERY envvar should set up child processes, and this seems to fix my local doc build.

Side note: when I use our OSMesa-built VTK with libosmesa6 on debian, I get a bunch of the following errors:

 2022-06-05 13:33:24.714 (1293.272s) [        31440740]   vtkTextureObject.cxx:1025   ERR| vtkTextureObject (0x1bd06450): Attempt to use a texture buffer exceeding your hardware's limits. This can happen when trying to color by cell data with a large dataset. Hardware limit is 65536 values while 871306 was requested.

I don't know if this is due to the VTK build or the libosmesa system package, but I wonder if we can do something about this, and whether this poses an issue during the actual doc build.

@adeak adeak added bug Uh-oh! Something isn't working as expected. documentation Anything related to the documentation/website labels Jun 5, 2022
@codecov
Copy link

codecov bot commented Jun 5, 2022

Codecov Report

Merging #2745 (01fc342) into main (904b986) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2745   +/-   ##
=======================================
  Coverage   93.83%   93.83%           
=======================================
  Files          76       76           
  Lines       16232    16232           
=======================================
  Hits        15231    15231           
  Misses       1001     1001           

@akaszynski
Copy link
Member

I'd prefer this in lieu of #2744. Rest of discussion is there.

Copy link
Contributor

@MatthewFlamm MatthewFlamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@akaszynski akaszynski mentioned this pull request Jun 5, 2022
@tkoyama010
Copy link
Member

Suggest merging on June 6th.

@adeak
Copy link
Member Author

adeak commented Jun 5, 2022

superseded by #2746

@adeak adeak closed this Jun 5, 2022
@akaszynski
Copy link
Member

Reopening based on #2746 (comment)

Recommend merge ASAP as a hotfix.

@akaszynski akaszynski reopened this Jun 5, 2022
@akaszynski akaszynski merged commit 2f1b011 into pyvista:main Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Uh-oh! Something isn't working as expected. documentation Anything related to the documentation/website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants