Fix the error running by CodeQL. #2772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2772 +/- ##
=======================================
Coverage 93.86% 93.86%
=======================================
Files 76 76
Lines 16230 16230
=======================================
Hits 15235 15235
Misses 995 995 |
|
While I think this is a great idea for some projects, I question its usage for pyvista as we're not really web-based and codeql seems to be focused on that domain. This will add another 7 minutes to our build jobs. Nonetheless, I think we should try it out for a bit. If it's not adding value, we can always remove it later on. |
|
That is exactly right. This function is in the GitHub setup and I added it out of curiosity. I welcome to revert it right away if we feel bothered. I love to try everything. |
tkoyama010
changed the title
tkoyama010
commented
Jun 12, 2022
akaszynski
approved these changes
Jun 12, 2022
There was a problem hiding this comment.
LGTM. Thanks for looking into this @tkoyama010, I've learned something new today!
|
Suggest to merge on 2022/6/14. |
akaszynski
pushed a commit
that referenced
this pull request
Jun 14, 2022
* Create codeql-analysis.yml * Update README.rst * Update app.py * Fix by isort * Delete codeql-analysis.yml * Apply suggestions from code review
akaszynski
added a commit
that referenced
this pull request
Jun 18, 2022
* do not deep copy on assigning scalars * fix garbage collection * clean up collection test * add types * fix docstring * fix docstring * fix type * Rename shallow copy, fix some typos * Apply suggestions from code review Co-authored-by: Andras Deak <adeak@users.noreply.github.com> * cleanup based on suggestions * always return pyvista_ndarray * Update tests/test_utilities.py Co-authored-by: Andras Deak <adeak@users.noreply.github.com> * return only pyvista_ndarray * fix test * add missing image cache png (#2765) * Update information on the translation project (#2743) * Update information of translation project * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review * Update doc/index.rst Co-authored-by: Alex Kaszynski <akascap@gmail.com> Co-authored-by: Andras Deak <adeak@users.noreply.github.com> * Update hypothesis requirement from <6.47.1 to <6.47.2 (#2771) Updates the requirements on [hypothesis](https://github.com/HypothesisWorks/hypothesis) to permit the latest version. - [Release notes](https://github.com/HypothesisWorks/hypothesis/releases) - [Commits](HypothesisWorks/hypothesis@hypothesis-ruby-0.0.1...hypothesis-python-6.47.1) --- updated-dependencies: - dependency-name: hypothesis dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * update pre-commit hooks (#2776) Co-authored-by: akaszynski <akaszynski@users.noreply.github.com> * Add fill arg to Polygon (#2767) * Add generate_polygon arg to Polygon * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Andras Deak <adeak@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Andras Deak <adeak@users.noreply.github.com> * skip or avoid creating files in doc build (#2748) * skip or avoid creating files in doc build * remove mention of _get_default_tempdir * Fix the error running by CodeQL. (#2772) * Create codeql-analysis.yml * Update README.rst * Update app.py * Fix by isort * Delete codeql-analysis.yml * Apply suggestions from code review * Add extrude_trim filter (#2600) * Add extrude-trim.py * Add example comment * Add test * Add an inplace test * Add extrude_trim filter * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review * Update pyvista/core/filters/poly_data.py Co-authored-by: Phil Chiu <whophil@users.noreply.github.com> * Apply suggestions from code review * Fix by black * Fix by isort * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: MatthewFlamm <39341281+MatthewFlamm@users.noreply.github.com> * improve example Co-authored-by: Phil Chiu <whophil@users.noreply.github.com> Co-authored-by: MatthewFlamm <39341281+MatthewFlamm@users.noreply.github.com> Co-authored-by: Alex Kaszynski <akascap@gmail.com> * Update hypothesis requirement from <6.47.2 to <6.47.3 (#2780) Updates the requirements on [hypothesis](https://github.com/HypothesisWorks/hypothesis) to permit the latest version. - [Release notes](https://github.com/HypothesisWorks/hypothesis/releases) - [Commits](HypothesisWorks/hypothesis@hypothesis-ruby-0.0.1...hypothesis-python-6.47.2) --- updated-dependencies: - dependency-name: hypothesis dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fail when regression image is missing on CI (#2778) * optionally fail when image is missing * use in linux tests instead of windows * remove failing test * Return correct scalar type for pyvista_ndarray (#2770) * fix return types * override __array_wrap__ * Apply suggestions from code review * Update pyvista/core/pyvista_ndarray.py Co-authored-by: Andras Deak <adeak@users.noreply.github.com> Co-authored-by: Andras Deak <adeak@users.noreply.github.com> * fix docstring return types * cleanup docs * remove code duplication * Minor improvements from code review * move complex collection test to test_collection * Apply suggestions from code review Co-authored-by: Andras Deak <adeak@users.noreply.github.com> * Fix array retrieval for VTK objects, add tests for coverage Co-authored-by: Andras Deak <adeak@users.noreply.github.com> Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: akaszynski <akaszynski@users.noreply.github.com> Co-authored-by: Phil Chiu <whophil@users.noreply.github.com> Co-authored-by: MatthewFlamm <39341281+MatthewFlamm@users.noreply.github.com> Co-authored-by: Andras Deak <deak.andris@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
CodeQL is the code analysis engine developed by GitHub to automate security checks. You can analyze your code using CodeQL and display the results as code scanning alerts. For more information about CodeQL, see "About code scanning with CodeQL." (Quote from here)Fix the error running by CodeQL.
Details