-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deep/shallow copy metadata #2779
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2779 +/- ##
==========================================
+ Coverage 93.86% 93.88% +0.01%
==========================================
Files 76 76
Lines 16230 16265 +35
==========================================
+ Hits 15235 15270 +35
Misses 995 995 |
adeak
reviewed
Jun 13, 2022
adeak
reviewed
Jun 13, 2022
adeak
reviewed
Jun 13, 2022
CI failure is unrelated, due to an ongoing "incident" with GitHub Actions Cache. |
adeak
approved these changes
Jun 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As pointed out in this comment, metadata is always shallow copied (or not at all) when copying datasets:
This should be
False
.On the other hand, the textures themselves are always shallow copied, but a new set is created, being neither a shallow or deep copy.
Solution
This PR cleans up
copy_meta_from
and cleans up the implementation to either perform a true "deep copy" or "shallow copy" depending on thedeep
parameter.