Add warning when trying to screenshot while using a jupyter_backend #2795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banesullivan
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2795 +/- ##
=======================================
Coverage 93.92% 93.93%
=======================================
Files 76 76
Lines 16329 16331 +2
=======================================
+ Hits 15337 15340 +3
+ Misses 992 991 -1 |
akaszynski
approved these changes
Jun 17, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a
jupyter_backend, passingscreenshotto theshow()call silently fails. This PR adds warning. IMO, we should fix this more completely such that ifscreenshotis specified, it always executes a screenshot.