Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes regarding optional dependencies #2826

Merged
merged 2 commits into from
Jun 21, 2022

Conversation

akaszynski
Copy link
Member

Resolve #2688 by adding notes on the optional dependencies.

Also includes ipyvtklink and pythreejs as optional dependencies to both [all] and the new [jupyter] sections. Given the rise and popularity of jupyterlab, I think we should have this included.

@github-actions github-actions bot added the documentation Anything related to the documentation/website label Jun 19, 2022
@codecov
Copy link

codecov bot commented Jun 19, 2022

Codecov Report

Merging #2826 (bc09356) into main (7df4de5) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2826      +/-   ##
==========================================
- Coverage   94.02%   94.00%   -0.03%     
==========================================
  Files          76       76              
  Lines       16395    16390       -5     
==========================================
- Hits        15415    15407       -8     
- Misses        980      983       +3     

doc/getting-started/installation.rst Outdated Show resolved Hide resolved
doc/getting-started/installation.rst Outdated Show resolved Hide resolved
Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>
Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkoyama010 tkoyama010 merged commit 604ba90 into main Jun 21, 2022
@tkoyama010 tkoyama010 deleted the docs/installation_optional_dep branch June 21, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the documentation/website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

meshio excluded from pip install
2 participants