fix extent documentation and implementation #2827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2827 +/- ##
==========================================
+ Coverage 94.00% 94.03% +0.02%
==========================================
Files 76 76
Lines 16390 16399 +9
==========================================
+ Hits 15407 15420 +13
+ Misses 983 979 -4 |
normanius
reviewed
Jun 19, 2022
akaszynski
commented
Jun 20, 2022
adeak
reviewed
Jun 20, 2022
akaszynski
commented
Jun 20, 2022
akaszynski
commented
Jun 20, 2022
akaszynski
commented
Jun 20, 2022
Co-authored-by: Andras Deak <adeak@users.noreply.github.com>
adeak
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2821 by moving the implementation to
pyvista.UniformGrid. It should not be apyvista.DataSetattribute as this attribute is not applicable for allpyvista.DataSets. Just like how we do not implementdimensionfor apyvista.PolyData, there's no reason to implementextentfor anything except for the classes that have extent.While other "Grid-like" classes have
GetExtentandSetExtentimplemented,SetExtentrequiresintand does not accept floats, making it poorly suited for these classes as they can return a float extent but cannot accept one.