Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jupyterlab to Scooby Report #2846

Merged
merged 4 commits into from
Jun 25, 2022
Merged

Add jupyterlab to Scooby Report #2846

merged 4 commits into from
Jun 25, 2022

Conversation

banesullivan
Copy link
Member

This would be useful to include in the Report when helping people debug in-notebook rendering.

@pyvista/developers, any other packages we may want to add while this is open?

@github-actions github-actions bot added the bug Uh-oh! Something isn't working as expected. label Jun 22, 2022
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #2846 (e4f023a) into main (5c36c18) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2846   +/-   ##
=======================================
  Coverage   94.03%   94.03%           
=======================================
  Files          76       76           
  Lines       16399    16399           
=======================================
  Hits        15420    15420           
  Misses        979      979           

Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Suggest merging on 2022/6/24.

@akaszynski
Copy link
Member

any other packages we may want to add while this is open?

Two others.

Co-authored-by: Alex Kaszynski <akascap@gmail.com>
@tkoyama010 tkoyama010 added maintenance Low-impact maintenance activity and removed bug Uh-oh! Something isn't working as expected. labels Jun 24, 2022
@github-actions github-actions bot added the bug Uh-oh! Something isn't working as expected. label Jun 24, 2022
@akaszynski akaszynski merged commit d1e17d3 into main Jun 25, 2022
@akaszynski akaszynski deleted the patch/report-jupyterlab branch June 25, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Uh-oh! Something isn't working as expected. maintenance Low-impact maintenance activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants