Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _version.py file reference in CONTRIBUTING.rst #2861

Merged
merged 4 commits into from
Jun 26, 2022

Conversation

adeak
Copy link
Member

@adeak adeak commented Jun 25, 2022

There was a stale reference in the "make a patch release" notes to __version__.py, now pyvista/_version.py.

@adeak adeak added the documentation Anything related to the documentation/website label Jun 25, 2022
Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. LGTM.

@codecov
Copy link

codecov bot commented Jun 25, 2022

Codecov Report

Merging #2861 (be7735e) into main (257f4aa) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2861      +/-   ##
==========================================
- Coverage   94.09%   94.03%   -0.06%     
==========================================
  Files          76       76              
  Lines       16426    16426              
==========================================
- Hits        15456    15447       -9     
- Misses        970      979       +9     

@tkoyama010 tkoyama010 added documentation Anything related to the documentation/website and removed documentation Anything related to the documentation/website labels Jun 25, 2022
@tkoyama010 tkoyama010 enabled auto-merge (squash) June 26, 2022 20:50
@tkoyama010 tkoyama010 merged commit d3a51be into pyvista:main Jun 26, 2022
@akaszynski
Copy link
Member

@tkoyama010, I've disabled requiring the triage workflow.

@tkoyama010
Copy link
Member

@akaszynski Sorry for bothering you. I reported it at mheap/github-action-required-labels#33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the documentation/website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants