Implement fixes for VTK 9.2.0rc #2863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
Codecov Report
@@ Coverage Diff @@
## main #2863 +/- ##
==========================================
- Coverage 94.09% 94.08% -0.01%
==========================================
Files 76 76
Lines 16426 16443 +17
==========================================
+ Hits 15456 15471 +15
- Misses 970 972 +2 |
2 tasks
tkoyama010
reviewed
Jun 26, 2022
adeak
reviewed
Jun 27, 2022
Co-authored-by: Andras Deak <adeak@users.noreply.github.com>
Co-authored-by: Andras Deak <adeak@users.noreply.github.com>
|
@banesullivan, could you review so we could have this merged tomorrow? I'm hoping for a v0.35.1 (not v0.35.0 because I screwed that release up) by the end of the week. |
akaszynski
added a commit
that referenced
this pull request
Jun 29, 2022
* add fixes for py310 * add windows and mac to testing * improve coverage * Update pyvista/core/filters/data_set.py Co-authored-by: Andras Deak <adeak@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Andras Deak <adeak@users.noreply.github.com> * add crushed can example Co-authored-by: Andras Deak <adeak@users.noreply.github.com>
4 tasks
akaszynski
added a commit
that referenced
this pull request
Jun 30, 2022
* Fix imports of vtkExtractEdges and vtkCellTreeLocator (#2585) These classes have been moved and imports failed. This checks for VTK versions/builds and imports them accordingly. * Implement fixes for VTK 9.2.0rc (#2863) * add fixes for py310 * add windows and mac to testing * improve coverage * Update pyvista/core/filters/data_set.py Co-authored-by: Andras Deak <adeak@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Andras Deak <adeak@users.noreply.github.com> * add crushed can example Co-authored-by: Andras Deak <adeak@users.noreply.github.com> * bump to v0.34.2 * don't use cache * Fix use of a slice tuple for numpy 1.23 (#2726) * remove more cache Co-authored-by: Håkon Strandenes <h.strandenes@km-turbulenz.no> Co-authored-by: Andras Deak <adeak@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds fixes for vtk 9.2 release candidate.
Regressions (VTK side):
Other changes:
GetErrortoGetThresholdErrorfor image comparison.