Tecplot ascii data reader #2875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🚀 Thanks for opening your first pull request in PyVista! 🚀 Please make sure you read (skim 😉) our Contributing Guide and abide by our Code of Conduct.
A few things to keep in mind:
- Remember to run the tests locally to make debugging issues easier.
- If you need help writing tests, take a look at the existing ones for inspiration. If you do not know where to start, let
@pyvista/developersknow and we will walk you through it. - All new features should be documented. It helps to write the docstrings for your functions/classes before writing the code. This will help you think about your code design and results in better code.
- No matter what, we are really grateful that you put in the effort to open this PR! ⭐
Codecov Report
@@ Coverage Diff @@
## main #2875 +/- ##
==========================================
+ Coverage 94.03% 94.08% +0.04%
==========================================
Files 76 76
Lines 16426 16428 +2
==========================================
+ Hits 15447 15457 +10
+ Misses 979 971 -8 |
mechajeff
commented
Jun 27, 2022
tkoyama010
requested changes
Jun 27, 2022
Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>
Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>
mechajeff
commented
Jun 27, 2022
tkoyama010
previously approved these changes
Jun 27, 2022
akaszynski
reviewed
Jun 27, 2022
There was a problem hiding this comment.
Also needs to be added to https://github.com/pyvista/pyvista/blob/main/doc/api/readers/index.rst#reader-classes
Added in a8e43fe. Sorted the lines as well. |
akaszynski
reviewed
Jun 27, 2022
github-actions
bot
added
the
documentation
akaszynski
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This feature adds a Tecplot ascii .dat file reader. Tecplot is a common format for computational fluid dynamics and finite element model data.
Details
Adds Tecplot ascii format data files to the list of PyVista readers. The reader creates a MultiBlock data object of the information. A tecplot example file is included in vtk_data. A test was inclued in tests/utilites/test_reader.py