Ensure data remains a shallow copy when added to plotter #2888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2888 +/- ##
==========================================
- Coverage 94.11% 94.06% -0.05%
==========================================
Files 76 76
Lines 16521 16521
==========================================
- Hits 15549 15541 -8
- Misses 972 980 +8 |
banesullivan
previously approved these changes
Jun 28, 2022
tkoyama010
requested changes
Jun 28, 2022
Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>
banesullivan
previously approved these changes
Jun 29, 2022
banesullivan
approved these changes
Jun 29, 2022
tkoyama010
approved these changes
Jun 29, 2022
adeak
added a commit
to adeak/pyvista
that referenced
this pull request
Jul 6, 2022
* upstream/main: Add setup and teardown functionality to plot_directive (pyvista#2907) Update hypothesis requirement from <6.48.4 to <6.49.2 (pyvista#2942) Bump lxml from 4.9.0 to 4.9.1 (pyvista#2936) Bump typing-extensions from 4.2.0 to 4.3.0 (pyvista#2939) Update hypothesis requirement from <6.48.3 to <6.48.4 (pyvista#2938) Bump trimesh from 3.12.6 to 3.12.7 (pyvista#2937) Update information of release (pyvista#2911) update pre-commit hooks (pyvista#2931) Handle invalid theme on init (pyvista#2917) Add `py.typed` Marker (pyvista#2904) [create-pull-request] update local intersphinx (pyvista#2926) Add tags with python commands to avoid misnumbering (pyvista#2416) Fix the url link of discretize (pyvista#2914) Add DataSet.cell_point_ids (pyvista#2897) Update hypothesis requirement from <6.48.2 to <6.48.3 (pyvista#2918) Ensure data remains a shallow copy when added to plotter (pyvista#2888)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #2461 by ensuring that a shallow copied dataset remains shallow when added to a plotter.