Improve ChartMPL performance #2943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2943 +/- ##
=======================================
Coverage 94.07% 94.08%
=======================================
Files 76 76
Lines 16534 16538 +4
=======================================
+ Hits 15555 15559 +4
Misses 979 979 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As pointed out in #2932, the
_redrawmethod ofChartMPLinstances was called excessively (on every VTK render step), causing some performance issues.Resolves #2932.
Details
With this PR,
ChartMPLinstances are only redrawn when the matplotlib figure changes (draw_eventcallback) or the Plotter window is resized.