Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add_mesh_slice_orthogonal() when a name is passed #2950

Merged
merged 3 commits into from
Jul 7, 2022

Conversation

banesullivan
Copy link
Member

@banesullivan banesullivan commented Jul 7, 2022

Fixes name issue in add_mesh_slice_orthogonal, see #2949

@github-actions github-actions bot added the bug Uh-oh! Something isn't working as expected. label Jul 7, 2022
@banesullivan banesullivan marked this pull request as draft July 7, 2022 16:52
@banesullivan banesullivan marked this pull request as ready for review July 7, 2022 17:01
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #2950 (e49da9a) into main (47ddcd9) will decrease coverage by 0.00%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##             main    #2950      +/-   ##
==========================================
- Coverage   94.30%   94.30%   -0.01%     
==========================================
  Files          76       76              
  Lines       16527    16533       +6     
==========================================
+ Hits        15586    15591       +5     
- Misses        941      942       +1     

@adeak adeak changed the title Fix #2949 Fix add_mesh_slice_orthogonal() when a name is passed Jul 7, 2022
@adeak adeak linked an issue Jul 7, 2022 that may be closed by this pull request
1 task
@akaszynski akaszynski added this to the 0.35.0 milestone Jul 7, 2022
@akaszynski akaszynski enabled auto-merge (squash) July 7, 2022 21:32
@akaszynski akaszynski merged commit 58d9ed7 into main Jul 7, 2022
@akaszynski akaszynski deleted the patch/slice-orthogonal-name branch July 7, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Uh-oh! Something isn't working as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plotter.add_mesh_slice_orthogonal broken when a name passed
2 participants