-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a few minor contour()-related issues #2951
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2951 +/- ##
=======================================
Coverage 94.30% 94.30%
=======================================
Files 76 76
Lines 16527 16535 +8
=======================================
+ Hits 15586 15594 +8
Misses 941 941 |
This is good to go as-is. Coverage will be fixed in #2952. Recommending immediate merge once all but codecov is passing. |
I was about to recommend merging yours first because there's probably overlap with this one for the scalars type checking things :) Whichever direction works for you. (Even codecov should be good now.) |
I'll merge mine first once approved. |
* upstream/main: Enforce scalar output for contour filter (pyvista#2952)
Merging this with the hope to get 0.35.0 out by the end of the day. This breaks the 24H rule, but as this is a small bug fix, I'm sure we'll be forgiven. |
For what it's worth I consider "impending release" to be an exception to review pedantry, see #2245 (reply in thread). |
This is a collection of minor things I came across while debugging #2901.
rng
range incontour()
should be a sorted(min, max)
pair, otherwise we raise.contour()
should be allowed to be lists and other array-likes.Since the same error appears when (i) the scalar name is invalid, and (ii) when it refers to cell scalars, and (iii) when the explicit scalars array passed is consistent with cell scalars, I decided to simplify it just to say that we need point scalars.