pythreejs: support surface mesh front/back face culling #2983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2983 +/- ##
=======================================
Coverage 95.16% 95.16%
=======================================
Files 83 83
Lines 18476 18480 +4
=======================================
+ Hits 17583 17587 +4
Misses 893 893 |
tkoyama010
reviewed
Jul 16, 2022
|
I can add tests for this, but will take a bit. |
akaszynski
approved these changes
Oct 11, 2022
|
Automerging, this is near trivial. |
|
Ignoring doc failure due to charts. Will fix in follow-up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For use with
Plotter.add_mesh(..., culling='front'/'back'