Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docstring default for log_scale in add_mesh #3028

Merged
merged 1 commit into from Jul 19, 2022
Merged

Fix docstring default for log_scale in add_mesh #3028

merged 1 commit into from Jul 19, 2022

Conversation

MatthewFlamm
Copy link
Contributor

Overview

Fixes description of default log_scale in add_mesh.

Details

See

pyvista/pyvista/plotting/plotting.py

Line 1854 in 647181b

log_scale=False,

@github-actions github-actions bot added the bug Uh-oh! Something isn't working as expected. label Jul 18, 2022
@MatthewFlamm MatthewFlamm added documentation Anything related to the documentation/website bug Uh-oh! Something isn't working as expected. and removed bug Uh-oh! Something isn't working as expected. labels Jul 18, 2022
@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #3028 (c67c2e6) into main (647181b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3028   +/-   ##
=======================================
  Coverage   94.37%   94.37%           
=======================================
  Files          76       76           
  Lines       16541    16541           
=======================================
  Hits        15611    15611           
  Misses        930      930

akaszynski
akaszynski approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tkoyama010
tkoyama010 approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akaszynski akaszynski merged commit 8887b85 into main Jul 19, 2022
@akaszynski akaszynski deleted the fix-log-scale-default-description branch July 19, 2022 16:18
@akaszynski akaszynski added this to the 0.35.3 milestone Jul 29, 2022
akaszynski pushed a commit that referenced this pull request Jul 30, 2022
@MatthewFlamm @akaszynski
Fix docstring default for log_scale in add_mesh (#3028)
4ccbb23
This was referenced Jul 30, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkoyama010 tkoyama010 tkoyama010 approved these changes

@akaszynski akaszynski akaszynski approved these changes

Assignees
No one assigned
Labels
bug Uh-oh! Something isn't working as expected. documentation Anything related to the documentation/website
Projects
None yet
Milestone
0.35.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MatthewFlamm @tkoyama010 @akaszynski