New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GIF reader and implement tight plotting for 2D #3038
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3038 +/- ##
==========================================
+ Coverage 94.37% 94.39% +0.01%
==========================================
Files 76 76
Lines 16541 16630 +89
==========================================
+ Hits 15611 15698 +87
- Misses 930 932 +2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far. I had many thoughts on future implementations from this PR, some of which I mentioned here. Feel free to ignore those to keep this PR manageable.
Ha! There's only like 10 comments. "Manageable" is sub-300 when GitHub starts breaking down because @adeak found 200 edge cases, typos, and general things I didn't think about. Honestly, I've learned so much about software engineering because you guys are so critical, I appreciate the feedback. |
@MatthewFlamm, when you get a second, would you mind giving this a quick review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I like this |
Add a basic GIF reader. This is needed for testing of a separate animation PR.